Skip to content

add callin tests #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2020
Merged

add callin tests #246

merged 2 commits into from
Jun 14, 2020

Conversation

artemredkin
Copy link
Collaborator

Add tests that execute delegate backpressure call-ins on a different EL

Motivation:
Programming model: all call-outs and call-ins have to be on the task EL, we need to add a safeguard so it would not be accidentally broken.

Modifications:
Adds a test that calls-in on a different EL

Result:
Closes #222

@artemredkin artemredkin requested a review from weissi June 13, 2020 18:28
Copy link
Contributor

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@weissi weissi merged commit 5e3b77b into swift-server:master Jun 14, 2020
@artemredkin artemredkin deleted the add_callin_tests branch June 14, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for delegate callins
2 participants